[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28179 [Core Tor/Tor]: Handle output from PT processes with the event loop
#28179: Handle output from PT processes with the event loop
-----------------------------------------+---------------------------------
Reporter: ahf | Owner: ahf
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version: Tor:
| unspecified
Severity: Normal | Resolution:
Keywords: tor-pt, 040-roadmap-subtask | Actual Points:
Parent ID: #25502 | Points:
Reviewer: dgoulet | Sponsor: Sponsor8
-----------------------------------------+---------------------------------
Comment (by dcf):
https://github.com/torproject/tor/pull/537/files#diff-
08bd8435ecfd8690789652091567ff47R1151
{{{
/* The format is 'LOG <transport> <message>'. We accept empty messages.
*/
}}}
It looks like this comment is out of date; I thought the `<transport>`
part was removed. Also "We accept empty messages" seems to contradict the
"Managed proxy sent us a LOG line with missing arguments" check above: I
suppose that `LOG ` (with a space) is acceptable but `LOG` is not, not
sure if that's what's intended.
https://github.com/torproject/tor/pull/537/files#diff-
6fdba7a022e591369dcf7054e5f2700aR7396
{{{
/** A pluggable transport called <b>transport_name</b> has emitted a log
* message found in <b>message</b>. */
void
control_event_transport_log(const char *transport_name, const char
*message)
{
send_control_event(EVENT_TRANSPORT_LOG,
"650 TRANSPORT_LOG %s %s\r\n",
transport_name,
message);
}
}}}
Where does `<transport_name>` come from? Is it the path the executable? In
general, tor won't know a specific transport name corresponding to any LOG
message. I don't see where `control_event_transport_log` is called other
than in tests.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28179#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs