[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28640 [Applications/Tor Browser]: System addon does not override app-profile addon

#28640: System addon does not override app-profile addon
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201811,    |  Actual Points:
  TBA-a2                                         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the work, sysrqb! Nicely done. I picked the patches more or
 less as-is to get the build going. The result of that is 4 commits on
 `tor-browser-60.3.0esr-8.5-1` (commit
 62ec69b09ff02649b3eab64a08fa87549c0bfc16,
 20f13426dec48e7b3b1df2cbd6cc41b3432fa267,
 bd3d1614a144377b32f5f548ce235c8ae0fb01d8, and
 10ca4718681668db7b0bdba0e3dd207dbe352cd8).

 Review comments:

 5f3ee64a5dcfeb884c56ee12124d0ad6166badff - I don't think there is a need
 to invoke all the preprocessing machinery here. We could do like we did in
 #27763 I think, just using `AppConstants.platform === "android"` (which we
 already have in `XPIInstall.jsm`)

 d43b65d65952ac47f6cd4cc12237dbd4a51fa36b - okay

 d56596ea32fd4499a0d6656fa5e80689110da263 - okay

 c32f80a0ad33140d1058df9845cbea92938c5c10 - this needs some considerable
 clean-up. I think we should make the result another commit starting with
 "Bug 28507". That way all the things are grouped together and easier to
 find.

 Could you try making the summaries of your commit message shorter (I know
 it is hard sometimes!)? Having those super long lines makes it harder to
 read through the log in a terminal (I generally found
 https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html to
 be reasonable with good arguments but that's just a personal opinion).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28640#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs