Re: [tor-bugs] #28602 [Core Tor/sbws]: The call to generate the bw file is passing an old argument

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28602: The call to generate the bw file is passing an old argument
------------------------------------------+--------------------------------
 Reporter:  juga                          |          Owner:  juga
     Type:  defect                        |         Status:  needs_revision
 Priority:  Medium                        |      Milestone:  sbws:
                                          |  1.0.x-final
Component:  Core Tor/sbws                 |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  sbws-1.0-must-moved-20181128  |  Actual Points:
Parent ID:  #25925                        |         Points:
 Reviewer:                                |        Sponsor:
------------------------------------------+--------------------------------

Comment (by juga):

 Replying to [comment:8 teor]:
 > This patch changes the meaning of --torflow-round-digs, which is also a
 breaking change.

 Assuming that by default we want to use --round-digs (unless --torflow-
 round-digs is provide), what do you suggest?, use that option when it's
 provided and use --round-digs by default?, should --round-digs still
 exist?.

 > When you make changes after a review, please keep the same branch, and
 use fixup commits.
 > Then the reviewer can just review the new changes.

 Sorry i didn't realize it was reviewed, interpreted it as a comment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28602#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs