[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32342 [Applications/Tor Browser]: Tor Browser for Android crashes when opening the locale pane in the settings



#32342: Tor Browser for Android crashes when opening the locale pane in the
settings
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:  fixed
 Keywords:  tbb-mobile, tbb-crash,               |  Actual Points:
  tbb-9.0-issues, tbb-regression,                |
  tbb-9.0.1-can, TorBrowserTeam201911R           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:13 sysrqb]:
 > Okay, it looks like this patch works (at least as far as it `stores`
 omni.ja instead of deflating it).
 >
 > {{{
 > $ unzip -vl testbuild/tor-browser-tbb-nightly-android-x86_64-multi-
 qa.apk | grep omni.ja
 > 11117897  Stored 11117897   0% 2000-01-01 00:00 6516d0c2  assets/omni.ja
 > }}}
 >
 > I pushed branch `bug32342_00`. I tested it and changing locales does not
 result in the app crashing anymore.

 Looks good to me. I wonder whether the fix has any new reproducibility
 implications. Like, are the new `zip` incantations causing issues? I
 guess, we'll find that out soon... ;) Anyway, I applied the patch to
 `master` (commit 3c7fb0e610a4f85d7b157221ac9049d99d958c24) and `maint-9.0`
 (commit 3d5f4308312bdece464dba6b55ef0be33f6bb257) so that both the
 upcoming 9.5a1 and 9.0.1 have the fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32342#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs