[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30866 [Core Tor/Tor]: Teach config.c to work with options configured in other modules
#30866: Teach config.c to work with options configured in other modules
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #29211 | Points: 2
Reviewer: teor | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
I like the design here. I am looking forward to being able to disable the
dirauth and relay options in a generic way.
I did a review of the code on GitHub - I had some questions, and found
some typos.
I expect that we will have some parseconf tests in this branch, or some
more unit tests (or both). I opened #32374 to make it easier to test
options_act*(). It would have been helpful in #32213, and would also help
with testing this ticket.
I resolved a conflict between #32339 and #32344 when merging to master, so
this branch needs to be rebased.
Can we squash the "Use the confdecl.h macros to declare a crypto_options_t
struct" and WIP commits, so that the eventual code is cleaner? Or just
delete the draft "Use the confdecl.h macros to declare a crypto_options_t
struct" ?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30866#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs