[tor-bugs] #32463 [Core Tor/Tor]: TypeError in practracker "includes.py" script

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32463: TypeError in practracker "includes.py" script
--------------------+------------------------------
 Reporter:  opara   |          Owner:  (none)
     Type:  defect  |         Status:  new
 Priority:  Low     |      Component:  Core Tor/Tor
  Version:          |       Severity:  Minor
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
 Reviewer:          |        Sponsor:
--------------------+------------------------------
 When practracker finds a forbidden include, it causes a Python TypeError.
 Example:


 {{{
 user@computer:~/tor$ make check-includes
 python3 ./scripts/maint/practracker/includes.py .
 Unusual pattern permitted.h in ./scripts/maint/practracker/testdata
 Forbidden include of lib/lock/compat_mutex.h at
 ./src/lib/evloop/eventqueue.h:8
 Traceback (most recent call last):
   File "./scripts/maint/practracker/includes.py", line 285, in <module>
     main(sys.argv)
   File "./scripts/maint/practracker/includes.py", line 282, in main
     list_advisories=args.list_advisories)
   File "./scripts/maint/practracker/includes.py", line 240, in
 run_check_includes
     files in its enclosing directory.""".format(RULES_FNAME))
 TypeError: 'Error' object is not callable
 make: *** [check-includes] Error 1
 }}}

 This seems to be caused by an err() function being removed from the code
 sometime in the past, but the call to err() was never also removed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32463>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs