[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30237 [Applications/Tor Browser]: Tor Browser: Improve TBB UI of hidden service client authorization

#30237: Tor Browser: Improve TBB UI of hidden service client authorization
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201911R, network-      |  Actual Points:
  team-roadmap-september                         |
Parent ID:  #30000                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by mcs):

 * keywords:  TorBrowserTeam201911, network-team-roadmap-september =>
     TorBrowserTeam201911R, network-team-roadmap-september
 * status:  needs_revision => needs_review


Comment:

 Thanks again for the review. We addressed most of the issues mentioned in
 comment:33 and fixed a couple of other issues we found. We did not add
 `const` everywhere; Kathy and I are still not sure if that is a good idea
 given the trade-offs. As Georg mentioned in comment:34, we should have the
 #26184 discussion (and probably a general coding style discussion) within
 the team. The bulk of the work we did was to make things more modular,
 moving most of the code into a new `onionservices` browser component.

 Here are two new Torbutton commits (both pushed to brade's bug30237-03
 branch):
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug30237-03&id=f774d8858b4c52dcdadc7f7d67c5cb4d8a21527d

 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug30237-03&id=4edfada7d1da1f19403eb9a52d372793a1f6945f

 (we did not make any changes to the second one).

 And here is a revised tor-browser commit (pushed to brade's bug30237-03
 branch):
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug30237-03&id=509999fe8ef29fa3cb2915bdfb050d4512014081

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30237#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs