[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32516 [Applications/Tor Browser]: Make Write Methods Clearer in TorConfigBuilder

#32516: Make Write Methods Clearer in TorConfigBuilder
----------------------------------------------+----------------------------
 Reporter:  sisbell                           |          Owner:  tbb-team
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911  |  Actual Points:
Parent ID:                                    |         Points:  .25
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by sisbell):

 * status:  new => needs_review


Comment:

 Ready for Review. No breaking API changes.

 Changes
 * Added write line and write properties methods and used throughout
 property settings
 * Did a format on the code to clear up previously flag nits
 * I added a write address method. Its currently unused now but will be
 used in subsequent commits

 https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/1f95271ae222839797825020a41491ac8aab0d8f

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32516#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs