Re: [tor-bugs] #30767 [Applications/Tor Browser]: Custom obfs4 bridge does not work on Tor Browser for Android

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30767: Custom obfs4 bridge does not work on Tor Browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-parity, tbb-mobile,              |  Actual Points:
  TorBrowserTeam201911                           |
Parent ID:  #31284                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor30-can
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:17 sysrqb]:
 > Looks pretty good.
 >
 > {{{
 > +    @SettingsConfig
 > +    public TorConfigBuilder bridgesFromSettings() {
 > +        List<String> supportedBridges =
 settings.getListOfSupportedBridges();
 > +        if (supportedBridges == null || supportedBridges.isEmpty()) {
 > +            return this;
 > +        }
 > +        String type = supportedBridges.contains("meek") ? "meek_lite" :
 "obfs4";
 > }}}
 > Do we still use both? obfs4 now has support for meek, so I assume we
 simply can do the same. As an example, I have this in my Tor Browser
 torrc:
 > {{{
 > ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec
 ./TorBrowser/Tor/PluggableTransports/obfs4proxy
 > }}}
 >
 > ------------
 > {{{
 > -        if(hasAddedBridge) useBridges();
 > }}}
 > I don't see any other `useBridges()` calls, do we need an unconditional
 call now?
 I looked through the bridge settings code. Since UseBridges is 0 by
 default, the following methods needs to be changed to write bridges if
 enabled.


 {{{
     @SettingsConfig
     public TorConfigBuilder useBridgesFromSettings() {
         return !settings.hasBridges() ? dontUseBridges() : this;
     }
 }}}

 to

 {{{
     @SettingsConfig
     public TorConfigBuilder useBridgesFromSettings() {
         return settings.hasBridges() ? useBridges() : this;
     }
 }}}

 There is one other use of useB

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30767#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs