[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32534 [Applications/Tor Browser]: settle on one canonical jtorctl

#32534: settle on one canonical jtorctl
-------------------------------------------------+-------------------------
 Reporter:  eighthave                            |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, tbb-mobile, jtorctl,        |  Actual Points:
  TorBrowserTeam202001                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by eighthave):

 The
 [https://github.com/torproject/tor/blob/6a490d3032fa8d368bb54bd479b61c2bcbd45c8f/src/feature/control/control_cmd.c#L2287
 list of public commands] isn't so long, and they're mostly implemented.  I
 was thinking we should have them all implemented so that the library only
 needs to change if the commands change.   That said, the list of conf and
 info options is long, but those are reachable using
 `GETINFO`/`GETCONF`/etc/, so I don't think we need more of an API there.

 So something like this should probably stay out of the library:
 {{{
     public void resetOwningControllerProcess() throws IOException {
         resetConf(Collections.singleton("__OwningControllerProcess"));
     }
 }}}

 Here's the public list of commands:

  * ADD_ONION
  * ATTACHSTREAM
  * AUTHCHALLENGE
  * AUTHENTICATE
  * CLOSECIRCUIT
  * CLOSESTREAM
  * DEL_ONION
  * DONE
  * DROPGUARDS
  * DROPOWNERSHIP
  * ERROR
  * EXTENDCIRCUIT
  * GETCONF
  * GETINFO
  * HSFETCH
  * HSPOST
  * LOADCONF
  * MAPADDRESS
  * POSTDESCRIPTOR
  * PROTOCOLINFO
  * REDIRECTSTREAM
  * RESETCONF
  * RESOLVE
  * SAVECONF
  * SETCIRCUITPURPOSE
  * SETCONF
  * SETEVENTS
  * SETROUTERPURPOSE
  * SIGNAL
  * TAKEOWNERSHIP
  * USEFEATURE

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32534#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs