Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32500: consider clang -std=gnu99 in Travis for better C99 portability
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.3
  035-backport, 040-backport, 041-backport,      |
  042-backport                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:5 teor]:
 > Replying to [comment:4 nickm]:
 > > Are we doing this with all clang builds, or only some clang builds? I
 vote for "only some", since we may build differently (eg with different
 autoconf results) if we do _not_ have std=gnu99 set.
 >
 > catalyst had the same question in #tor-dev, so I've changed Travis to
 run using a macOS `clang -std=gnu99`, and a Linux `gcc -std=gnu99`. (Just
 in case gcc has extra warnings, too.)
 >
 > There are fewer conflicts, so we just need to merge:
 > * 0.2.9: ​https://github.com/torproject/tor/pull/1539
 > * 0.3.5: ​https://github.com/torproject/tor/pull/1540
 >
 > Test branches are here:
 > * https://travis-ci.org/teor2345/tor/branches
 Thanks! Mostly looks good. Your
 [https://github.com/teor2345/tor/commits/ticket32500_master
 ticket32500_master] branch seems to be failing Travis. It looks like a
 coccinelle problem, so maybe it's unrelated? Maybe you could try rebasing
 it to see if it was a transient coccinelle problem on master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32500#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs