[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32610 [Core Tor/Tor]: Add macro spacing checks to "make check-spaces"

#32610: Add macro spacing checks to "make check-spaces"
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  teor
     Type:  enhancement                    |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.3.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  0.2
Parent ID:  #32522                         |         Points:  0.2
 Reviewer:  nickm                          |        Sponsor:  Sponsor31-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 See my PR:
 * master: https://github.com/torproject/tor/pull/1566

 I ended up implementing:
 * check `else {`
 * check all the preprocessor directives we currently use
 * check for no spaces and multiple spaces (in cases where that makes
 sense)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32610#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs