[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability
#32500: consider clang -std=gnu99 in Travis for better C99 portability
-------------------------------------------------+-------------------------
Reporter: catalyst | Owner: teor
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: portability, tor-ci, 029-backport, | Actual Points: 0.3
035-backport, 040-backport, 041-backport, |
042-backport |
Parent ID: | Points: 0.1
Reviewer: catalyst | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Comment (by catalyst):
Replying to [comment:9 teor]:
> There's definitely something weird going on here.
>
> The -std=gnu99 flag shouldn't affect coccinelle, but maybe it's reading
the contents of $CC, and interpreting them differently?
> It's also weird that the gcc/trusty build fails, but the clang/macOS
build passes.
Yeah those inconsistencies bother me as well.
Also I think coccinelle will see `CC=gcc` in its environment. (We pass
`CC="$CC -std=gnu99"` to `./configure`, but that shouldn't change the `CC`
environment variable.
For what it's worth, I'm not able to reproduce this failure on Xenial.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32500#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs