[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31531 [Core Tor/Tor]: Make control_event_conf_changed() take a smartlist of config_line_t

#31531: Make control_event_conf_changed() take a smartlist of config_line_t
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  neel
     Type:  defect          |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:  0.5
 Reviewer:  catalyst        |        Sponsor:  Sponsor31-can
----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 neel]:
 > PR: https://github.com/torproject/tor/pull/1558
 Thanks! This mostly looks good.

 `config_line_t` is already a linked list; why not pass that linked list to
 `control_event_conf_changed()` instead of repackaging it into a smartlist?
 That seems to me like it would be simpler.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31531#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs