[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21952 [Applications/Tor Browser]: Onion-location: increasing the use of onion services through automatic redirects and aliasing
#21952: Onion-location: increasing the use of onion services through automatic
redirects and aliasing
-------------------------------------------------+-------------------------
Reporter: linda | Owner: acat
Type: project | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, tor-hs, network-team- | Actual Points: 9
roadmap-november, TorBrowserTeam201911, |
tbb-9.5 |
Parent ID: #30024 | Points: 6
Reviewer: | Sponsor:
| Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by acat):
* status: needs_revision => needs_review
* actualpoints: 5.5 => 9
Comment:
Revised branch for review in https://github.com/acatarineu/tor-
browser/commits/21952+2.
I split the changes into two commits for reviewing purposes, UI and
"internals" needed for the http redirect. For the internals, I used a
couple of flags (`LOAD_FLAGS_ONION_REDIRECT` and `LOAD_ONION_REDIRECT`)
the value of which I think is not used anywhere else. But as I said, I'm
not sure if it would be better to rewrite that commit and use the
`redirectTo` JavaScript API instead. For the UI, you'll see that the
notification title does not look exactly the same as in
https://trac.torproject.org/projects/tor/attachment/ticket/21952/21952%20-%20UI%20Review.png.
But I tried to use only the JS API to save a few lines of css and markup,
and thought this was close enough to be acceptable. But feel free to
insist if you still think the notification should be closer to
`UI_review.png` one. I'll update with build + snapshot/video later.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21952#comment:85>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs