[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1859 [Tor Client]: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and client

#1859: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and
client
------------------------+---------------------------------------------------
 Reporter:  mwenge      |       Owner:  mwenge             
     Type:  defect      |      Status:  needs_review       
 Priority:  minor       |   Milestone:  Tor: 0.2.2.x-final 
Component:  Tor Client  |     Version:  Tor: 0.2.2.12-alpha
 Keywords:              |      Parent:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 Reviewing:

   * In the future, please use an nice narrow linewidth for your commit
 messages.  Pretend it's a text email. :)
   * In circuit_discard_optional_exit_enclaves, instead of get_by_hexdigest
 you need to say router_get_by_digest(): a hex digest is only going to work
 if it's hex-encoded, which extend-info identity_digest isn't.
   * Same problem for rend_client_get_random_intro: you're doing a
 get_by_hexdigest on identity_digest.  Also, identity_digest might not be
 set yet! The point of that block is to go from a name for the intro point
 (which might be all we have from some hidden server descriptor versions)
 to its extend_info.
   * Also in rend_client_get_random_intro: That one was a get_by_nickname
 because, before 0.1.2.18/0.2.0.7-alpha, hidden services could list their
 introduction points by nickname.  I think it might be okay to break hidden
 services running from such old Tors, but I'm not certain.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1859#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs