[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #988 [Tor Relay]: Different TLS certs for incoming vs outgoing

#988: Different TLS certs for incoming vs outgoing
--------------------------+-------------------------------------------------
 Reporter:  arma          |         Type:  enhancement
   Status:  needs_review  |     Priority:  minor      
Milestone:  post 0.2.1.x  |    Component:  Tor Relay  
  Version:  0.2.0.34      |   Resolution:  None       
 Keywords:                |       Parent:             
--------------------------+-------------------------------------------------

Comment(by Sebastian):

 I can't reproduce any crash. As far as review, I think
 public_server_mode() is an unfortunate function name. To me it immediately
 implied that we'd be dealing with the PublishServerDescriptor options,
 instead of a simple bridge check. I generally wonder if it is necessary to
 make this distinction at all, because I can't see how it would hurt to
 maintain separate client and server certs for public relays. Maybe I'm
 missing something here?

 The functions want better documentation wrt accepted parameters and return
 values, I think. Also a changes file is missing.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/988#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs