[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4125 [Tor Relay]: Implement proposal 176 (renegotiation-free handshake)

#4125: Implement proposal 176 (renegotiation-free handshake)
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:  nickm              
     Type:  enhancement  |         Status:  needs_review       
 Priority:  normal       |      Milestone:  Deliverable-Nov2011
Component:  Tor Relay    |        Version:                     
 Keywords:               |         Parent:                     
   Points:               |   Actualpoints:                     
-------------------------+--------------------------------------------------

Comment(by asn):

 Replying to [comment:4 asn]:
 > * In or_handshake_state_record_cell() and
 or_handshake_state_record_var_cell() in the case of:
 > {{{
 >   if (! *dptr)
 >      *dptr = crypto_new_digest256_env(DIGEST_SHA256);
 > }}}
 > shouldn't the new `dptr` be attached somewhere?
 >

 Oops, just read that code carefully again, `dptr` is already attached to
 `state`. nvm.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4125#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs