Re: [tor-bugs] #4200 [Tor Directory Authority]: Write a patch that tracks (bridge) server descriptor downloads (total requests per day, unique requests)

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#4200: Write a patch that tracks (bridge) server descriptor downloads (total
requests per day, unique requests)
-------------------------------------+--------------------------------------
 Reporter:  Sebastian                |          Owner:                     
     Type:  enhancement              |         Status:  needs_review       
 Priority:  normal                   |      Milestone:  Deliverable-Nov2011
Component:  Tor Directory Authority  |        Version:                     
 Keywords:                           |         Parent:                     
   Points:                           |   Actualpoints:                     
-------------------------------------+--------------------------------------

Comment(by nickm):

 The "rep_hist_add_desc_stats" identifier seems vague.  How about
 rep_hist_note_desc_served() or something?

 The documentation for "served_descs" should say what the keys and values
 of the map are.

 I'd be more comfortable if rep_hist_desc_stats_init() were idempotent --
 that is, if it did "if (served_descs) return;" rather than
 "tor_assert(!served_descs)".

 In rep_hist_format_desc_stats, if time moves backwards we'll be sad.

 As a separate patch, we should raise the "write a stats file code" into a
 function of its own.  I added ticket #4282 for that.

 Otherwise looks fine.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4200#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs