[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #4320 [Tor Client]: Audit functions called during options_act_reversible()
#4320: Audit functions called during options_act_reversible()
------------------------+---------------------------------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
While reviewing #4196, I wondered if it is actually safe to call
parse_client_ports() from inside options_act_reversible(), because
parse_client_ports() with its second argument set to 0 has a side effect.
This shouldn't be allowed during options_act_reversible(), because we
can't undo that change in the case of an error.
I suspect other issues like this may also exist. We should check to make
sure all the functions don't modify state in a way we can't undo, or
change the logic behind options_act_reversible() generally.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4320>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs