[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7011 [Tor]: Stored IPv6 TransportProxy bindaddr lacks brackets



#7011: Stored IPv6 TransportProxy bindaddr lacks brackets
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  asn               
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-bridge  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by aagbsn):

 Replying to [comment:15 dcf]:
 > Replying to [comment:13 aagbsn]:
 > > BridgeDB parses IPv6 transport lines. See:
 https://tor.extc.org/?transport=obfs2&ipv6=True :-)
 >
 > So what is it doing, is it assuming that the last colon in an
 address:port string is always a port separator, even when address is IPv6
 without brackets? The code in comment:5 would, for example, format the
 address 1234::5678 and port 9999 as
 > {{{
 > transport foo 1234::5678:9999
 > }}}
 > and not
 > {{{
 > transport foo [1234::5678]:9999
 > }}}
 >
 > So in other words, is there code somewhere that already expects IPv6
 addresses in transport lines not to have brackets, and are we going to
 break it if we add brackets?

 No, I should have clarified. BridgeDB expects IPv6 addresses to be
 bracketed, just like the "or-address" and "a" lines are. If you -don't-
 add brackets, BridgeDB will not parse the IP and skip the line.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7011#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs