[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7112 [Tor]: tor_addr_is_internal_() - non-IP address of type 0
#7112: tor_addr_is_internal_() - non-IP address of type 0
-----------------------------------+----------------------------------------
Reporter: mazda | Type: defect
Status: new | Priority: major
Milestone: Tor: 0.2.4.x-final | Component: Tor
Version: | Keywords: tor_addr_is_internal
Parent: | Points:
Actualpoints: |
-----------------------------------+----------------------------------------
Comment(by andrea):
This gets triggered when we have an anonymized directory connection linked
to an exit connection, as created in connection_exit_connect_dir();
write_http_response_header_impl() then calls is_local_addr() on a zeroed-
out address field and emits the warning. Best fix is to track which
server-side dir_connection_ts are anonymous and avoid calling
is_local_addr() on them - the is_local_dir() test controls writing an X
-Your-Address-Is HTTP header, and that's not meaningful anyway in this
case.
There's already a dirconn_direct field which gets set to false on the
client side in the anonymous directory connection case, but which as far
as I can tell is always zero on the server side. It has a bunch of
associated comments about that being a bad name. I propose renaming it to
dirconn_anonymous, inverting the sense in the client case, and setting it
on the server side from connection_exit_connect_dir(). Then we can test
it in write_http_response_header_impl() and avoid calling is_local_addr().
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7112#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs