[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7191 [Tor]: smartlist_bsearch_idx() is broken for short lists

#7191: smartlist_bsearch_idx() is broken for short lists
-----------------------------------------+----------------------------------
 Reporter:  andrea                       |          Owner:  andrea            
     Type:  defect                       |         Status:  needs_review      
 Priority:  major                        |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor                          |        Version:  Tor: 0.2.4.3-alpha
 Keywords:  tor-relay denial-of-service  |         Parent:                    
   Points:                               |   Actualpoints:                    
-----------------------------------------+----------------------------------

Comment(by andrea):

 Replying to [comment:10 nickm]:
 > Maybe we should forget that I said "for 0.2.3 purposes" then and just
 look whether any of these asserts could/should be LD_BUG.
 >
 > "No they shouldn't'" is one possible answer.

 To repeat and amplify from IRC: all the asserts in the new
 smartlist_bsearch_idx() I wrote are either "someone passed us a NULL
 argument" or "something is inconsistent with what the logic of the
 function requires should be the case, so this can only happen if this is
 horribly buggy."  I don't think there's any reasonable thing the function
 can return in those cases, so asserting is the right choice.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7191#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs