[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7260 [Tor]: MinGW64 & -Werror -Werror

#7260: MinGW64 & -Werror -Werror
--------------------+-------------------------------------------------------
 Reporter:  yayooo  |          Owner:                    
     Type:  defect  |         Status:  needs_revision    
 Priority:  normal  |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor     |        Version:  Tor: 0.2.3.24-rc  
 Keywords:          |         Parent:                    
   Points:          |   Actualpoints:                    
--------------------+-------------------------------------------------------
Changes (by rransom):

  * status:  new => needs_revision


Comment:

 re MinGW64.patch (with SHA-256
 4f142e2dbb33c786333e9b8e7936d181f1407c705a2a2046a128f964506e155c):
  * `_MSC_VER` should be replaced with an âare we using Microsoft's C
 runtime library on Windowsâ macro, not with a list of three macros which
 happen to usually mean that Tor is being linked against that library.
  * Whether procmon.c typedefs `pid_t` or not should be determined by an
 autoconf test (like the way that src/common/util.c decides whether to
 define `environ`).

 Werror.patch appears to contain several unrelated changes which should be
 split into separate patches.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7260#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs