Re: [tor-bugs] #6877 [Tor]: Finally replace all char[] buffers with uint8_t[] buffers

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#6877: Finally replace all char[] buffers with uint8_t[] buffers
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 Wow, thanks!

 This is a ~5000 line patch series, so reviewing it is going to be a tiny
 bit slow, but I'll try to chug through it piece by piece.  It compiles
 without warnings for me, so that's a good sign.

 baf7eb6762befb40e86fdc0d337408329b031537:
   * crypto_add_spaces_to_fp and crypto_pk_get_fingerprint probably should
 still use char *, not uint8_t, since it's working on human-readable
 strings.

 858ccbd17f9fe4bd36b049ab484b4fe1e4ed4e01:
   * looks okay.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6877#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs