[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8506 [Ooni]: Provide OONI packages for Debian

#8506: Provide OONI packages for Debian
------------------------+----------------------
     Reporter:  lunar   |      Owner:  lunar
         Type:  task    |     Status:  accepted
     Priority:  normal  |  Milestone:
    Component:  Ooni    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------

Comment (by aagbsn):

 Replying to [comment:21 lunar]:
 > Having that `Makefile` ''installed'' in the datadir is useless. Once I
 have `/usr/share/ooni/Makefile`, what should I do with it? `sudo make -C
 /usr/share/ooni` is pretty weird thing to type. It also adds an extra
 dependency on make.
 >
 > IMHO, what it does should either be included in ooni-probe itself
 (`ooni-probe --download-extra-resources`) or documented as something to
 run before running `setup.py install` or integrated in `setup.py`
 (`setup.py configure` maybe?)â But shipping a Makefile as an installed
 file is very weird.

 >
 > Also, I don't understand why the example configuration goes into
 `datadir`. Is it used by the code of ooni-probe? If it is meant for human
 consumption, I'm not sure it's the right place to put it, but I don't know
 enough about Python packaging.

 The ooniprobe.conf.sample is read from /usr/share/ooni into the users home
 directory as ~/.ooni/ooniprobe.conf (where the user can edit it) upon
 instancing the ooni configuration object at runtime (if that directory and
 file does not already exist).

 The default value for option "data_dir" is /usr/share/ooni/, which is not
 user writable. If we add a command (post installation) to download the
 GeoIP data, we would also need to change the default path in the config
 file, and each user on a shared system would need their own copy of (not
 version controlled) GeoIP data. Meh.

 Perhaps we could leverage the existing tor-geoipdb and make that a
 dependency of ooniprobe. IIRC the format of tor-geoipdb might not be
 compatible with pygeoip, though. Or, perhaps we could package the MaxMind
 DB separately?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8506#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs