[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8510 [Tor]: Add useful Hidden Service related events to the Tor control port

#8510: Add useful Hidden Service related events to the Tor control port
-------------------------+----------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:  task     |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: unspecified
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs controller needs-proposal
Actual Points:           |  Parent ID:  #8993
       Points:           |
-------------------------+----------------------------------------------

Comment (by nickm):

 control_event_hs_descriptor_receive_end worries me a bit.  It takes a fmt
 argument as a char*, and bypasses the GCC printf argument checking.
 Instead, why not give it an extra const char * argument to receive either
 "FAILED" or "RECEIVED"?

 In test_hs.c, I'd suggest adding TT_FORK to the flags field, so that the
 tests are run in a subprocess.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8510#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs