[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by infinity0):

 This is ready to merge.

 https://github.com/infinity0/flashproxy/compare/master...common-toplevel

 I've settled on doing it the top-level way and added a big descriptive
 docstring to the top of setup-common.py

 I've also refactored Makefile a bit - Makefile retains the original dist
 /dist-exe targets (with exactly the same contents as before - I verified
 this), and Makefile.client deals with the client specifics. Although a bit
 more code, it is less entangled than before. In particular,
 Makefile.client adheres to the GNU conventions and "looks like" a normal
 source-package Makefile; and Makefile is a more coherent "composition" of
 the other per-component build scripts. (For example, now it is
 structurally possible to build dist and dist-exe in a single command line
 - that is if py2exe worked natively on Linux.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs