[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7359 [Tor]: Design/implement method for collecting/reporting statistics

#7359: Design/implement method for collecting/reporting statistics
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  robgjansen             |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.5.x-final
  enhancement            |    Version:
     Priority:  normal   |   Keywords:  performance, simulation,
    Component:  Tor      |  statistics, tor-relay, tor-client
   Resolution:           |  Parent ID:  #7357
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 The branch looks better now.  One change that it needs: you *don't* need
 to cast uint64_t * to const uint64_t * implicitly.  The cast is always
 safe, so C does it for you.  Doing the cast explitictly can hide bugs if
 the input is secretly the wrong type.

 >So, I now know how to use those commands, and I agree I should use them.
 But I'm not sure how you'd want the morestats4 branch to look like in the
 end.

 No need to use squash/apply with morestats4; but please use them the next
 time you're writing a branch

 ---

 This is good to merge, except that it gives me a bunch of merge conflicts
 that I'm not sure how to resolve.  Those surrounding
 cell_queue_append_packed_copy's interface are the most confusing.   Do you
 want to make a merge branch for me?  (To do this, start a new branch based
 on master, then merge morestats4 into it, resolve the conflicts, commit
 the merge, and push that branch.) This is better in this case than a
 rebase, since I'd need to review a rebased branch more or less from
 scratch and wouldn't have an easy time seeing what changed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7359#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs