[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9349 [Flashproxy]: flashproxy facilitator: Allow clients to specify transports

#9349: flashproxy facilitator: Allow clients to specify transports
----------------------------+--------------------------
     Reporter:  asn         |      Owner:  dcf
         Type:  task        |     Status:  needs_review
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:  #7167
       Points:              |
----------------------------+--------------------------

Comment (by asn):

 I looked at Ximin's `bug9349_server_endpoints` branch.  The changes were
 too many for thorough reviewing, but all in all it looks good.

 It would feel better with a bit more docs (`match()` needs a function doc,
 `_findPrefixesForSuffixes` too. It's not at all obvious what they do.)
 Also, an ASCII-art-like doc on how Endpoints and all the other classes fit
 together would be nice.

 Let's not have these changes block the deliverable though, if it's too
 much effort we can create tickets and fix them afterwards.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9349#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs