[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9974 [Flashproxy]: packaging and installation scripts for facilitator

#9974: packaging and installation scripts for facilitator
-----------------------------+--------------------------
     Reporter:  infinity0    |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by asn):

 * status:  new => needs_review


Comment:

 Took a look at the `fac-build` branch. I'm not familiar enough with
 autotools or distro default scripts to evaluate the correctness of the
 changes, but I agree with the logic behind the changes.

 Here are some nitpicky notes. Feel free to ignore both.

 * In `82e6dc766a2625f14599968e82fe3c6e5fbc704c` you moved `MaxClients` out
 of the `VirtualHost *:443` block, but AFAIK that was not a config error
 (as the git commit msg claims). Doesn't really matter, I guess.
 * This is not an issue, but it's worth noting that
 `4811b51af8a5bf5c97dd1053e89c091a07916f4a` kind of changes behavior, since
 it switches the old default gmail address to 'invalid'. This means that
 the `FACILITATOR_EMAIL_ADDR` '''needs''' to be edited before starting up
 `facilitator-email-poller`, which was not the case in the past. Maybe this
 should be documented somewhere, like we do for `/reg-email.pass` with
 `"Replace this file's contents with your Gmail app-specific password;"`?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9974#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs