Re: [tor-bugs] #13135 [Onionoo]: Support various fingerprint formats

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13135: Support various fingerprint formats
-----------------------------+--------------------------
     Reporter:  Sebastian    |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by karsten):

 Replying to [comment:7 iwakeh]:
 > The branch looks fine. (No problems when running it locally, but I had
 to start with fresh data.)

 In theory, starting with fresh data shouldn't have been necessary.
 Redeploying the .war or maybe even restarting Tomcat should be sufficient.
 Hmm.

 > In SummaryDocument (catch-statements around lines 52 and  65)
 > I'd rather log the DecoderException instead of totally ignoring it.
 > The DigestUtils or Base64 class could malfunction, or some other problem
 could happen. In such a case, there would be a hint in the log.

 True, we should log those things.

 > And the version in ResponseBuilder needs to be increased before the
 release.

 True.

 > The first time for using 'next_major_version_scheduled' :-)

 Indeed.

 However, there's still a problem with my branch: Tomcat interprets `+` in
 parameter values as space.  When I fetch the following URL either with
 curl or Firefox, the servlet sees the following search terms.

 {{{
 http://localhost:8080/onionoo/summary?search=S+1drLUSi/Sq+vGxcQlIjauTLDg

 Search terms: [S, 1drLUSi/Sq, vGxcQlIjauTLDg]
 }}}

 Maybe embedded Jetty doesn't do that?  Or maybe there's a fix to tell
 Tomcat not to interpret `+` as space?  Or maybe we should tell Onionoo
 clients to escape/substitute the `+` character in base64 searches (ugh)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13135#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs