Re: [tor-bugs] #12210 [Tor Support]: Display comment when chat session begins

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12210: Display comment when chat session begins
-----------------------------+--------------------------
     Reporter:  lunar        |      Owner:  Sherief
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Tor Support  |    Version:
   Resolution:               |   Keywords:  pups
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by Sherief):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:6 lunar]:
 > Please use topic branch in the future. E.g. âbug12210â.
 >
 > {{{
 > + toAssistant = typeof toAssistant == 'undefined' ? false : true;
 > }}}
 >
 > Mhâ Why do you need to spell boolean values explicitely?

 You are absolutely right, this line was completely unnecessary. Fixed in:
 https://github.com/SheriefAlaa/pups/commit/93196c65a5619adbb29477c882d0e60756f2681e

 > {{{
 > - 'token': " Token: " + Prodromus.config.TOKEN
 > }}}
 >
 > Like last time. This is an array with strings for ''translation''. You
 can't put dynamic content in it like that.

 Exactly, I am removing not adding. The thing is that I can't remove the
 addition from history because it's already on tpo/pups.git/master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12210#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs