Re: [tor-bugs] #13558 [Tor Browser]: Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13558: Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the
download folder
-----------------------------+-----------------------
     Reporter:  cypherpunks  |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  minor        |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  tbb-crash
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------

Comment (by cypherpunks):

 Problem with [https://mxr.mozilla.org/mozilla-
 esr31/source/widget/windows/nsFilePicker.cpp#545 code]:
 {{{
 browserInfo.lParam = (LPARAM) aInitialDir.get();
 }}}

 But compiler generates instructions:
 {{{
 .6A76D41C: 833F00                 cmp         d,[edi],0
 .6A76D41F: 0F95C0                 setnz       al
 .6A76D422: 0FB6C0                 movzx       eax,al
 .6A76D425: 89442438               mov         [esp][038],eax
 }}}
 Which equal to:
 browserInfo.lParam = *(DWORD *)aInitialDir.get() != 0;

 So browserInfo.lParam can be 0 or 1 only, while internally it used as
 pointer to unicode string.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13558#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs