[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13577 [Tor]: Fix clang compilation warnings in tor, trunnel

#13577: Fix clang compilation warnings in tor, trunnel
------------------------+------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  clang
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by nickm):

 Yes, please send me the trunnel thing as a patch on trunnel.

 Other than that, I like all of this except for the part where we liter the
 code with !!.  That clang warning doesn't seem to me like it's actually
 making our code any cleaner; it's making it more confusing.  Can we move
 those !!s into the macros in question, or turn the macros into inline
 functions, or something like that?  Alternatively, I wouldn't mind -Wno-
 parenthesis-equality.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13577#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs