[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11291 [Tor]: Support group readable hidden service directories

#11291: Support group readable hidden service directories
-----------------------------+--------------------------------
     Reporter:  anon         |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-hs
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by asn):

 David asked me to review branch `ticket-11291-extra-utests`. It looks good
 to me.

 I would maybe document a bit more the `mask` stuff in
 `check_private_dir()` because it was not obvious to me what the mask is
 for and why it was not needed before:
 {{{
   if (check & (CPD_GROUP_OK|CPD_GROUP_READ)) {
     mask = 0027;
   } else {
     mask = 0077;
   }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11291#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs