[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13399 [Tor]: New digest256map_t type; use it for microdescriptors.

#13399: New digest256map_t type; use it for microdescriptors.
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_review


Comment:

 I have an implementation of digest256map_t in a branch "digest256map".

 This branch actually reduces the amount of code in container.c by using
 macros to instantiate strmap and digestmap, so that we can avoid cut-and-
 pasting the same code a third time into digest256map.

 Note that previously, our unit tests had complete line coverage for all
 the strmap/digestmap functions except for digestmap_assert_ok().  So the
 new code ought to have high coverage too, even though it's macro-
 generated.

 This does not implement the whole ticket here, but I'd like to get it
 reviewed and merged soon, since I think #12498 wants it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13399#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs