[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17115 [Onionoo]: Can't search by fingerprint with spaces

#17115: Can't search by fingerprint with spaces
-------------------------+--------------------------
     Reporter:  strugee  |      Owner:  phw
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |    Sponsor:
-------------------------+--------------------------
Changes (by karsten):

 * cc: iwakeh (added)
 * keywords:  easy =>
 * status:  new => needs_review


Comment:

 Wait, maybe there's a simpler way to implement this: we can extend the
 search parameter to support exact matching of any 4-character hex block in
 a space-separated fingerprint.  That is, in addition to checking if a
 search term is the beginning of a relay's fingerprint we can check if it
 matches one of the ten 4 hex characters in the relay's space-separated
 fingerprint.  This wouldn't require any input processing on client or
 server side.

 In the example above, this would work as follows:
  - `"DEFA"` matches part of the relay's nickname `"default"`,
  - `"CB7E"` is the beginning of the relay's fingerprint
 `"CB7E7D734E28312337DE322C1A0E4DE53578D2AE"` and exactly matches the first
 hex block, and
  - `"7D73"` exactly matches the second hex block of the relay's
 fingerprint.

 I implemented this idea in
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-17115
 branch task-17115 in my public repository].  I have some concerns that
 this will put more load on the Onionoo server, but I think I'm willing to
 risk that.  It's still a major protocol change where we should give client
 developers a 1-month warning.  But I'd want to start running it on
 https://onionoo.thecthulhu.com/ even before that to gather some feedback.
 I think I'll deploy it there in a few days, unless there are objections.
 Deployment on https://onionoo.torproject.org/ would happen around November
 15.

 Feedback welcome!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17115#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs