[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12967 [Tor Launcher]: Support a multi-lingual TBB that can switch between localizations
#12967: Support a multi-lingual TBB that can switch between localizations
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner: mcs
Type: enhancement | Status:
Priority: High | needs_revision
Component: Tor Launcher | Milestone:
Severity: Normal | Version:
Keywords: tbb-usability-stopppoint-wizard, | Resolution:
TorBrowserTeam201510R | Actual Points:
Parent ID: #17304 | Points:
Sponsor: SponsorU |
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:29 gk]:
> What about "generic"? Or what about "" (like tor-browser-
linux64-5.5a4.tar.xz) given that we only include the locales in the
package names as we ship differently localized bundles. If that is not
done anymore not confusing the user with either "ALL" or "generic" or ...
might be a good option?
Kathy really does not like "generic". She suggests we use "multi" instead.
And once we stop shipping the locale-specific packages we should remove
-multi from the download file names (but keep it internally as the update
locale). If it is important to avoid "multi" or another non-empty string
for update.locale then we will need to do more work.
> I think we should do the changes to the `versions.nightly` first. If the
patches stick in a nightly build we can use them for `versions.alpha` etc.
as soon as we tag a tor-launcher version.
OK; we will fix this when we revise the patch.
> It appears to me we only need one `cd mac-langpacks`/`cd
win32-langpacks`/`cd linux-langpacks` if we move them at the beginning of
the respective `for`-loop?
Looking at it some more, it seems better to avoid those cd's entirely. We
are going to try this in our revised patch.
> s/package names/package name/ (there is just one package with all
locales)
We will fix this.
>
> Linux only:
>
> "packages" -> "package" (we plan to create only one)
We will also fix this.
> whitespace between "popd" and "Set the update.locale"
I am not sure about this. In most places the gitian-bundle.yml scripts
avoid blank lines but there are some places where blank lines are used
(e.g., within the for loop where the locale-specific packages are
created). I personally prefer some blank lines because it makes navigation
easier within my editor, but it is not a big deal. It seems like we should
either try to use blank lines more or avoid them entirely. Which do you
prefer?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12967#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs