[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17305 [Tor Browser]: Make our Gitian setup able to build hardened Linux bundles (64bit)
#17305: Make our Gitian setup able to build hardened Linux bundles (64bit)
----------------------------------------------+--------------------------
Reporter: gk | Owner: gk
Type: task | Status: assigned
Priority: Very High | Milestone:
Component: Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-gitian, TorBrowserTeam201510 | Actual Points:
Parent ID: #17304 | Points:
Sponsor: SpnsorU |
----------------------------------------------+--------------------------
Comment (by mcs):
Replying to [comment:12 gk]:
> ...
> <number-a> would be "5" and <string-b> would be "a3-hardened". Looking
at the examples on that page (e.g. `1.0pre1 < 1.0pre2`) there should be no
issue for the comparator to estimate that `5.5a3-hardened <
5.5a4-hardened` holds especially as this works without "-hardened" very
well and "-hardened" is essentially an unchanging string. What am I
missing?
I think you are correct in saying that `5.5a3-hardened < 5.5a4-hardened`
will be true. It is only if we mix together things like ``5.5a3-hardened`
and < 5.5a3` that it gets confusing. I think for that case,
`5.5a3-SOMETHING` is always less than `5.5a3`. Some more details are
available here:
https://developer.mozilla.org/en-
US/docs/Toolkit_version_format#Comparing_versions
So, I think it will work if everything stays within the hardened channel
(but it is a little strange to encode the "hardened" concept in the
version number).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17305#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs