[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #13166 [metrics-lib]: Release metrics-lib version 1.0.0
#13166: Release metrics-lib version 1.0.0
-------------------------+-------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+-------------------------
Comment (by karsten):
Replying to [comment:6 iwakeh]:
> It might be good to also mention the used versions of the two
dependencies
> at least in CONTRIB.md (they are not listed in build.xml (yet?))
Good point, I just added version numbers to CONTRIB.md and to build.xml.
> Maybe, add to line 44:
> {{{
> Every public interface or method should have a comment ...
> Every new public interface or method should have a javadoc comment ...
> }}}
> the rest of the sentence explaines that we don't have it yet.
Hmm, I'm not sure what you have in mind. Can you paste the paragraph you
want here, and I'll copy it over?
> Why is there no third component for the version?
> It might be useful for troubleshooting and bugfixing to know exactly the
version that caused the problem. Unintended side-effects when cleaning the
code base or doing other minor changes could
> be more easily detected.
> Or, when keeping the two number versioning, maybe add the git revision
of the particular release
> to META-INF.
I don't feel strongly about either using two or three version components.
For Onionoo, it made sense to have three components (major protocol
changes, minor protocol changes, implementation changes). I only came up
with two components (major changes, minor changes), but I'd say if we can
come up with some reasonable guidelines for when we'd raise the three
version components for metrics-lib, let's have three of them. What would
such guidelines be?
Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13166#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs