[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #20277 [Core Tor/Tor]: Confusing "Not all bridges handle conditional consensus downloading" comment

#20277: Confusing "Not all bridges handle conditional consensus downloading"
comment
------------------------------+--------------------------------
     Reporter:  arma          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 There's this comment in directory.c:
 {{{
       /* XXX+++++ Not all bridges handle conditional consensus
 downloading,
        * so, for now, never assume the server supports that. -PP
        * Is that assumption still so in 2016? -NM */
 }}}

 And you're right, the conditional consensus stuff has been in since Tor
 0.2.1.x.

 So I went to go rip out the special-casing code, but it already got ripped
 out in git commit 7988596f (which went into Tor 0.2.4.2-alpha).

 And then, inexplicably, I seem to have added the stanza back in during git
 commit a8297cdbd3 (which went into Tor 0.2.4.11-alpha).

 I just looked around at the code some more and I'm now convinced that
 indeed that code is gone. We should fix the comments.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20277>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs