[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18529 [Core Tor/Tor]: Fix duplicate check for "only allow internal addresses if we are on a network with nonstandard authorities"
#18529: Fix duplicate check for "only allow internal addresses if we are on a
network with nonstandard authorities"
-------------------------------------------------+-------------------------
Reporter: nickm | Owner:
Type: defect | Status:
| merge_ready
Priority: Low | Milestone: Tor:
| 0.2.9.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.8.1-alpha
Severity: Trivial | Resolution:
Keywords: easy, refactor, 029-nickm-says-yes, | Actual Points:
review-group-3, nickm-deferred-20160905 |
Parent ID: | Points: 1
Reviewer: isis | Sponsor:
-------------------------------------------------+-------------------------
Comment (by nickm):
Thanks! I've merged this with a few changes:
1) I've made the function non-inline. Let's not inline things unless we
know they're going to slow down something that gets called a lot.
2) I've renamed the function.
3) I've removed the needless `? 1 : 0`.
Original patch merged as 1fc3e291083493; tweaked with 49d7feb8a0ec.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18529#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs