[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18910 [Metrics/CollecTor]: distributing descriptors accross CollecTor instances
#18910: distributing descriptors accross CollecTor instances
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: High | Milestone: CollecTor 1.1.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: ctip | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Comment (by iwakeh):
Please review this
[https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-18910
-first-sync-3&id=b998073dbf8ce8e6e728b6154b2b3ad8dcfc69ed third branch].
It contains two minor commits and a large big one (on top). The final
sync functionality with disabled ReferenceChecker.
I added tests for also checking the content of descriptor files. Thus,
the tests can now catch annotation issues. To have one place for all
annotation I introduced o.t.c.conf.Annotation, which at some point should
become metrics-lib code.
The persist package is corrected and the early line breaks in the paths
descriptions are there for more readability.
Files to 'recent' are first written to a temporary file and then renamed.
The current paths obey the new path structure. The way the paths are
defined now it is an easy task to change the structure in case if
necessary.
I think it is better to have it in one commit as all things belong
together and should be read and reviewed as a whole.
Well, can't think of anything else right now.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18910#comment:51>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs