[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20388 [Applications/Tor Browser]: Consolidate prefs usage in torbutton.js

#20388: Consolidate prefs usage in torbutton.js
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Minor                                |     Resolution:  fixed
 Keywords:  tbb-code-cleanup,                    |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by bugzilla):

 Replying to [comment:4 mcs]:
 > Replying to [comment:3 bugzilla]:
 > > Minor thing about prefs usage in torbutton.js:
 `extensions.torbutton.lastUpdateCheck` is set to `1475974589.6` instead of
 `1475974589600`.
 >
 > Does this cause buggy behavior or is it just surprising that `Date.now()
 / 1000` is stored without rounding to an integer?
 All other prefs with `lastUpdate` use integers. If you treat milliseconds
 as microseconds somewhere, it may lead to some surprises.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20388#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs