[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20394 [Applications/Tor Browser]: Remove dead code in torbutton

#20394: Remove dead code in torbutton
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-code-cleanup,                    |  Actual Points:
  TorBrowserTeam201610                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-code-cleanup, TorBrowserTeam201610R => tbb-code-cleanup,
     TorBrowserTeam201610
 * status:  needs_review => needs_revision


Comment:

 Two things:

 1) What about the `contents.rdf` file in `chrome/skin`?
 2) There is not `P0` anymore in `torbutton.js` after your clean-up, right?
 We should change comment on the first line accordingly then: s/P0/P1/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20394#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs