[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20404 [Metrics/metrics-lib]: DescriptorIndexCollector should be default implementation
#20404: DescriptorIndexCollector should be default implementation
---------------------------------+-----------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: High | Milestone: metrics-lib 1.4.1
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Comment (by karsten):
I think we're leaving third-party jars out of the release jar on purpose.
The idea is to avoid version conflicts where we'd be shipping an older or
newer version of a library that people use in their applications. I
vaguely remember that our version might take precedence over theirs, and
that can be bad.
So, in `CONTRIB.md` we write: "Whenever we add a new dependency, that's
clearly a major change that needs to be written into the change log,
because applications will have to add this dependency, too." We also
write: "For minor changes, we'd bump to x.x.1."
The question now is whether we can justify putting out a point release
with a major change. I lean towards no. And even a medium change might
require a bump to 1.5.0, though I'm less certain about that being a great
idea. The question is: should we just call this one 1.5.0 and bulk-change
tickets to move them to 1.6.0? Happy to create a milestone for that. Let
me know!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20404#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs