[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20394 [Applications/Tor Browser]: Remove dead code in torbutton
#20394: Remove dead code in torbutton
-------------------------------------------------+-------------------------
Reporter: arthuredelstein | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-code-cleanup, | Actual Points:
TorBrowserTeam201610R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):
* keywords: tbb-code-cleanup, TorBrowserTeam201610 => tbb-code-cleanup,
TorBrowserTeam201610R
* status: needs_revision => needs_review
Comment:
Replying to [comment:2 gk, comment 2]:
> Two things:
>
> 1) What about the `contents.rdf` file in `chrome/skin`?
> 2) There is not `P0` anymore in `torbutton.js` after your clean-up,
right? We should change comment on the first line accordingly then:
s/P0/P1/
Replying to [comment:3 gk, comment 3]:
> Oh, and a bug number in your commit message would be good. (although I
am usually fixing this if it's missing ;) )
All good points. Sorry for forgetting the bug number! Here is the branch
with fixes:
https://github.com/arthuredelstein/torbutton/commit/20394+1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20394#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs