Re: [tor-bugs] #20048 [Core Tor/Tor]: Introduce `smartlist_add_strdup()` function

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20048: Introduce `smartlist_add_strdup()` function
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:  0.3
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:5 icanhasaccount]:
 > Thank you for checking and for the feedback - I'll break the diff up
 into parts with a change file.

 Thanks!

 > Re the shortening thing - I explained that really badly. When reviewing
 the diff I noticed there are a few places (mostly in the test directory)
 where the pattern is:
 >
 > char *foo = tor_strdup("bar");
 > ....
 > smartlist_add(sl, foo);
 >
 > By shortening I meant I could go through and change those to use
 smartlist_add_strdup where appropriate afterwards.

 Yes, you can add another commit for that.
 (It's probably not worth making the coccinelle script smarter.)
 Are there any instances in the non-test code?

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20048#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs