[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20048 [Core Tor/Tor]: Introduce `smartlist_add_strdup()` function

#20048: Introduce `smartlist_add_strdup()` function
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:  0.3
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by icanhasaccount):

 Heya - I split the patch into 3 parts - one with the implementation, one
 to use smartlist_add_strdup for everywhere but src/test and a final patch
 for src/test.

 I had to change the following files in src/test by hand:

 test_shared_random.c
 test_routerset.c
 test_containers.c
 test_dir.c

 due to coccinelle errors - it really doesn't seem like the NS macro in
 particular. I tried various incantations/options without success but if
 anyone has any input on how to make it work properly I'll gladly redo.
 Also is posting the patches here okay or should I use github or somesuch
 thing?

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20048#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs